Stopwatch autoplay #18
Conversation
jquery.timer.js
Outdated
| this.pauseStart = 0; | ||
| this.setInterval(); | ||
|
|
||
| if (autostart != 0) { |
There was a problem hiding this comment.
Could be simplified to just if (autostart)
There was a problem hiding this comment.
Actually that line is there to keep autostart as the default behavior as currently stopwatch starts automatically? Because if someone does not pass the autostart variable within the constructor, then it won't start by default as the autostart variable will be undefined.
But anyway, changing it.
| }; | ||
|
|
||
| /** | ||
| * @param {function=} updateFunction |
There was a problem hiding this comment.
Mind updating the docblock? (also for the set function below)
|
@ozdemirburak Thanks for the PR! I'd be glad to add this. I left a few minor comments. Also, would you mind squashing your commits since all the changed lines will lose Git history (i.e. https://github.com/ozdemirburak/jquery-timer/blame/a6b47518ffc3827a774ed40d739b588ee80b047b/jquery.timer.js#L31). |
|
@jchavannes ping :) |
|
Merged. Thanks again @ozdemirburak :) |
2 participants
Added the optional autoplay option to stopwatch.
Sorry for the second commit as I, by default, use 2 spaces for indent :)